Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2025


This is an automatic backport of pull request #2828 done by [Mergify](https://mergify.com).

@christophfroehlich
Copy link
Member

image This ABI break is a thing here as we change the base class of the plugins, right? @saikishor

@saikishor
Copy link
Member

image This ABI break is a thing here as we change the base class of the plugins, right? @saikishor

Yes

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.47%. Comparing base (f220551) to head (d3d21e6).

Files with missing lines Patch % Lines
...roller_interface/src/controller_interface_base.cpp 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2843      +/-   ##
==========================================
- Coverage   89.48%   89.47%   -0.01%     
==========================================
  Files         152      152              
  Lines       17747    17761      +14     
  Branches     1448     1449       +1     
==========================================
+ Hits        15881    15892      +11     
- Misses       1291     1293       +2     
- Partials      575      576       +1     
Flag Coverage Δ
unittests 89.47% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntroller_interface/controller_interface_params.hpp 100.00% <ø> (ø)
...oller_interface/test/test_controller_interface.cpp 100.00% <100.00%> (ø)
controller_manager/src/controller_manager.cpp 77.08% <100.00%> (+0.01%) ⬆️
...ontroller_manager/test/test_controller_manager.cpp 96.22% <100.00%> (ø)
...roller_interface/src/controller_interface_base.cpp 86.82% <78.57%> (-0.92%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.08%. Comparing base (f220551) to head (cbb9b32).
⚠️ Report is 11 commits behind head on jazzy.

Files with missing lines Patch % Lines
...roller_interface/src/controller_interface_base.cpp 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2843      +/-   ##
==========================================
+ Coverage   89.48%   90.08%   +0.59%     
==========================================
  Files         152      152              
  Lines       17747    16564    -1183     
  Branches     1448     1291     -157     
==========================================
- Hits        15881    14921     -960     
+ Misses       1291     1130     -161     
+ Partials      575      513      -62     
Flag Coverage Δ
unittests 90.08% <83.33%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntroller_interface/controller_interface_params.hpp 100.00% <ø> (ø)
...oller_interface/test/test_controller_interface.cpp 100.00% <100.00%> (ø)
controller_manager/src/controller_manager.cpp 77.66% <100.00%> (+0.59%) ⬆️
...ontroller_manager/test/test_controller_manager.cpp 96.22% <100.00%> (ø)
...roller_interface/src/controller_interface_base.cpp 86.82% <78.57%> (-0.92%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants